Merged
Conversation
Contributor
Author
|
My most interesting build-contracts project atm is Reposoft/docker-httpd#4. These tests keep state under /tmp, which is sometimes helpful to inspect. |
atamon
reviewed
Sep 22, 2016
| cd $ROOT/build-contracts/ | ||
| for compose_file in $(ls | grep .yml); do | ||
| docker_compose="docker-compose -f $compose_file" | ||
| $docker_compose rm -f |
Contributor
There was a problem hiding this comment.
Maybe we could just remove this altogether? As we're doing --force-recreate anyways?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is a good idea, but I think so.
I think we need rm due to the confusion I myself experience with old logs shown in current docker-compose run.
But I also think we should avoid rm after the test, in case you need to analyze results.